fix: Updated logging in the client pool and client factory to log inf…

…ormation about the required transport and actual transport used. (#1853)
googleapis · May 30, 2023 · fe03d02 · fe03d02
1 parent 3dd53cf
commit fe03d02
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/dev/src/index.ts b/dev/src/index.ts
@@ -617,7 +617,12 @@ export class Firestore implements firestore.Firestore {
           );
         }
 
-        logger('Firestore', null, 'Initialized Firestore GAPIC Client');
+        logger(
+          'clientFactory',
+          null,
+          'Initialized Firestore GAPIC Client (useFallback: %s)',
+          useFallback
+        );
         return client;
       },
       /* clientDestructor= */ client => client.close()

diff --git a/dev/src/pool.ts b/dev/src/pool.ts
@@ -122,7 +122,12 @@ export class ClientPool<T> {
         this.concurrentOperationLimit - selectedClientRequestCount
       );
     } else {
-      logger('ClientPool.acquire', requestTag, 'Creating a new client');
+      logger(
+        'ClientPool.acquire',
+        requestTag,
+        'Creating a new client (requiresGrpc: %s)',
+        requiresGrpc
+      );
       selectedClient = this.clientFactory(requiresGrpc);
       selectedClientRequestCount = 0;
       assert(