doc: update README.md to show this library as GA #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Jan 29, 2019
README.md
Outdated
| }); | ||
| async function main() { | ||
| const firestore = new Firestore({ | ||
| projectId: process.env.GCLOUD_PROJECT, |
There was a problem hiding this comment.
I know you didn't do this (it was probs me), but can you remove the options getting passed into the constructor of the sample here? They aren't needed, like at all.
There was a problem hiding this comment.
👌
Made a separate PR #533 for this
| <img src="https://avatars2.githubusercontent.com/u/2810941?v=3&s=96" alt="Google Cloud Platform logo" title="Google Cloud Platform" align="right" height="96" width="96"/> | ||
|
|
||
| # [Google Cloud Firestore: Node.js Server SDK](https://github.com/googleapis/nodejs-firestore) | ||
| # [Google Cloud Firestore: Node.js Client](https://github.com/googleapis/nodejs-firestore) | ||
|
|
||
| [](https://cloud.google.com/terms/launch-stages) |
There was a problem hiding this comment.
wait - isn't this like the one thing that should change?
There was a problem hiding this comment.
Ah sorry I missed that, fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.