feat!: drop node8 support (#37)

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

.eslintrc.json

@@ -0,0 +1,3 @@
+{
+  "extends": "./node_modules/gts"
+}

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [8, 10, 12, 13]
+        node: [10, 12, 13]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1

.prettierrc.js

@@ -0,0 +1,17 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+module.exports = {
+  ...require('gts/.prettierrc.json')
+}

package.json

@@ -26,17 +26,18 @@
     "prelint": "cd samples; npm link ../; npm i"
   },
   "dependencies": {
-    "google-gax": "^1.14.2"
+    "google-gax": "^2.0.1"
   },
   "devDependencies": {
     "@types/mocha": "^7.0.0",
     "@types/node": "^12.0.0",
+    "@types/sinon": "^7.5.2",
     "c8": "^7.0.0",
     "eslint": "^6.8.0",
     "eslint-config-prettier": "^6.10.0",
     "eslint-plugin-node": "^11.0.0",
     "eslint-plugin-prettier": "^3.1.2",
-    "gts": "^1.0.0",
+    "gts": "2.0.0-alpha.9",
     "jsdoc": "^3.5.5",
     "jsdoc-fresh": "^1.0.1",
     "jsdoc-region-tag": "^1.0.2",
@@ -45,12 +46,13 @@
     "null-loader": "^3.0.0",
     "pack-n-play": "^1.0.0-2",
     "prettier": "^1.19.1",
+    "sinon": "^9.0.1",
     "ts-loader": "^6.2.1",
-    "typescript": "~3.6.4",
+    "typescript": "^3.8.3",
     "webpack": "^4.41.2",
     "webpack-cli": "^3.3.10"
   },
   "engines": {
-    "node": ">=8.13.0"
+    "node": ">=10"
   }
 }

protos/google/cloud/gaming/v1beta/common.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 

protos/google/cloud/gaming/v1beta/game_server_clusters.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -25,6 +24,7 @@ import "google/protobuf/timestamp.proto";
 import "google/api/annotations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";
 
@@ -35,7 +35,7 @@ message ListGameServerClustersRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/GameServerCluster"
+      child_type: "gameservices.googleapis.com/GameServerCluster"
     }
   ];
 
@@ -90,7 +90,7 @@ message CreateGameServerClusterRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/GameServerCluster"
+      child_type: "gameservices.googleapis.com/GameServerCluster"
     }
   ];
 
@@ -105,7 +105,12 @@ message CreateGameServerClusterRequest {
 message PreviewCreateGameServerClusterRequest {
   // Required. The parent resource name. Uses the form:
   // `projects/{project}/locations/{location}/realms/{realm}`.
-  string parent = 1 [(google.api.field_behavior) = REQUIRED];
+  string parent = 1 [
+    (google.api.field_behavior) = REQUIRED,
+    (google.api.resource_reference) = {
+      child_type: "gameservices.googleapis.com/GameServerCluster"
+    }
+  ];
 
   // Required. The ID of the Game Server Cluster resource to be created.
   string game_server_cluster_id = 2 [(google.api.field_behavior) = REQUIRED];
@@ -143,7 +148,12 @@ message DeleteGameServerClusterRequest {
 message PreviewDeleteGameServerClusterRequest {
   // Required. The name of the Game Server Cluster to delete. Uses the form:
   // `projects/{project}/locations/{location}/gameServerClusters/{cluster}`.
-  string name = 1 [(google.api.field_behavior) = REQUIRED];
+  string name = 1 [
+    (google.api.field_behavior) = REQUIRED,
+    (google.api.resource_reference) = {
+      type: "gameservices.googleapis.com/GameServerCluster"
+    }
+  ];
 
   // Optional. The target timestamp to compute the preview.
   google.protobuf.Timestamp preview_time = 2 [(google.api.field_behavior) = OPTIONAL];

protos/google/cloud/gaming/v1beta/game_server_clusters_service.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -23,6 +22,7 @@ import "google/cloud/gaming/v1beta/game_server_clusters.proto";
 import "google/longrunning/operations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";
 

protos/google/cloud/gaming/v1beta/game_server_configs.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -24,6 +23,7 @@ import "google/protobuf/timestamp.proto";
 import "google/api/annotations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";
 
@@ -35,7 +35,7 @@ message ListGameServerConfigsRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/GameServerConfig"
+      child_type: "gameservices.googleapis.com/GameServerConfig"
     }
   ];
 
@@ -91,7 +91,7 @@ message CreateGameServerConfigRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/GameServerConfig"
+      child_type: "gameservices.googleapis.com/GameServerConfig"
     }
   ];
 

protos/google/cloud/gaming/v1beta/game_server_configs_service.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -23,6 +22,7 @@ import "google/cloud/gaming/v1beta/game_server_configs.proto";
 import "google/longrunning/operations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";
 

protos/google/cloud/gaming/v1beta/game_server_deployments.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -25,6 +24,7 @@ import "google/protobuf/timestamp.proto";
 import "google/api/annotations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";
 
@@ -35,7 +35,7 @@ message ListGameServerDeploymentsRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/GameServerDeployment"
+      child_type: "gameservices.googleapis.com/GameServerDeployment"
     }
   ];
 
@@ -105,7 +105,7 @@ message CreateGameServerDeploymentRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/GameServerDeployment"
+      child_type: "gameservices.googleapis.com/GameServerDeployment"
     }
   ];
 

protos/google/cloud/gaming/v1beta/game_server_deployments_service.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -23,6 +22,7 @@ import "google/cloud/gaming/v1beta/game_server_deployments.proto";
 import "google/longrunning/operations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";
 
@@ -95,6 +95,11 @@ service GameServerDeploymentsService {
   }
 
   // Patches a single Game Server Deployment Rollout.
+  // The method will not return an error if the update does not affect any
+  // existing realms. For example - if the default_game_server_config is changed
+  // but all existing realms use the override, that is valid. Similarly, if a
+  // non existing realm is explicitly called out in game_server_config_overrides
+  // field, that will also not result in an error.
   rpc UpdateGameServerDeploymentRollout(UpdateGameServerDeploymentRolloutRequest) returns (google.longrunning.Operation) {
     option (google.api.http) = {
       patch: "/v1beta/{rollout.name=projects/*/locations/*/gameServerDeployments/*}/rollout"

protos/google/cloud/gaming/v1beta/realms.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -25,6 +24,7 @@ import "google/protobuf/timestamp.proto";
 import "google/api/annotations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";
 
@@ -35,7 +35,7 @@ message ListRealmsRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/Realm"
+      child_type: "gameservices.googleapis.com/Realm"
     }
   ];
 
@@ -90,7 +90,7 @@ message CreateRealmRequest {
   string parent = 1 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.resource_reference) = {
-      type: "gameservices.googleapis.com/Realm"
+      child_type: "gameservices.googleapis.com/Realm"
     }
   ];
 

protos/google/cloud/gaming/v1beta/realms_service.proto

@@ -1,4 +1,4 @@
-// Copyright 2019 Google LLC.
+// Copyright 2020 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//
 
 syntax = "proto3";
 
@@ -23,6 +22,7 @@ import "google/cloud/gaming/v1beta/realms.proto";
 import "google/longrunning/operations.proto";
 
 option go_package = "google.golang.org/genproto/googleapis/cloud/gaming/v1beta;gaming";
+
 option java_multiple_files = true;
 option java_package = "com.google.cloud.gaming.v1beta";