-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging.detectedResource
does not return "cloud_run_revision" on Cloud Run
#1127
Labels
api: logging
Issues related to the googleapis/nodejs-logging API.
lang: nodejs
Issues specific to JavaScript or TypeScript.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
product-auto-label
bot
added
the
api: logging
Issues related to the googleapis/nodejs-logging API.
label
Jul 29, 2021
minherz
added
lang: nodejs
Issues specific to JavaScript or TypeScript.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
and removed
triage me
I really want to be triaged.
labels
Aug 1, 2021
I encountered the same issue. Any ETA on a fix for this? |
I will have a look into it during this week (week 35). |
I will also look into the environment tests soon, since they are passing and they should be catching this |
averikitsch
changed the title
Cloud Run resource type not detected
Sep 1, 2021
logging.detectedResource
does not return "cloud_run_revision" on Cloud Run
minherz
added a commit
that referenced
this issue
Sep 1, 2021
Uses dedicated GCPEnv enumerator (CLOUD_RUN). Removes code that used COMPUTE_ENGINE enum with extra tests. Updates relevant unit tests. Fixes #1127
minherz
added a commit
that referenced
this issue
Sep 2, 2021
Uses dedicated GCPEnv enumerator (CLOUD_RUN). Removes code that used COMPUTE_ENGINE enum with extra tests. Updates relevant unit tests. Fixes #1127
daniel-sanche
pushed a commit
that referenced
this issue
Sep 2, 2021
Uses dedicated GCPEnv enumerator (CLOUD_RUN). Removes code that used COMPUTE_ENGINE enum with extra tests. Updates relevant unit tests. Fixes #1127
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Sep 2, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [9.5.7](https://www.github.com/googleapis/nodejs-logging/compare/v9.5.6...v9.5.7) (2021-09-02) ### Bug Fixes * Fix detecting Cloud Run logic ([#1145](https://www.github.com/googleapis/nodejs-logging/issues/1145)) ([99c276c](https://www.github.com/googleapis/nodejs-logging/commit/99c276cf0c394200836f3289ff21a4880523a7b5)), closes [#1127](https://www.github.com/googleapis/nodejs-logging/issues/1127) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/nodejs-logging API.
lang: nodejs
Issues specific to JavaScript or TypeScript.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
@google-cloud/logging
version: 9.5.4Steps to reproduce
The text was updated successfully, but these errors were encountered: