Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dry run support in Write API #711

Closed
Achuth17 opened this issue Feb 19, 2020 · 1 comment · Fixed by #712
Closed

Dry run support in Write API #711

Achuth17 opened this issue Feb 19, 2020 · 1 comment · Fixed by #712
Assignees
@zamnuts
Labels
api: logging Issues related to the googleapis/nodejs-logging API.

Comments

@Achuth17
Copy link

I am trying to set dryRun flag of the write api.

The WriteOptions interface does not support passing the dryRun boolean. Is there any other way to accomplish this?
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Feb 19, 2020
@stephenplusplus stephenplusplus self-assigned this Feb 19, 2020
@stephenplusplus
Copy link
Contributor

Looks like an oversight. I'll try to PR that real quick. Thanks for catching it!

@zamnuts zamnuts assigned zamnuts and unassigned stephenplusplus Feb 19, 2020
zamnuts added a commit to zamnuts/nodejs-logging that referenced this issue Feb 19, 2020
@zamnuts
fix(types): write options dryRun and partialSuccess (googleapis#711)
dd5b4b9
@zamnuts zamnuts mentioned this issue Feb 19, 2020
Merged
4 tasks
stephenplusplus pushed a commit that referenced this issue Feb 19, 2020
@zamnuts
fix(types): write options dryRun and partialSuccess (#711) (#712)
56a8ed8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zamnuts zamnuts

Labels
api: logging Issues related to the googleapis/nodejs-logging API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): write options dryRun and partialSuccess (#711) zamnuts/nodejs-logging
3 participants
@stephenplusplus @zamnuts @Achuth17