Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve compile errors #287

Merged
merged 1 commit into from
Oct 30, 2018
Merged

fix: resolve compile errors #287

merged 1 commit into from
Oct 30, 2018

Conversation

ofrobots
Copy link
Contributor

master was not compiling on my machine. This change picks up the latest @google-cloud/storage package with fixed types. Secondly, the getSinksStream is inferred to be typed as a Stream which doesn't have an end method. Even a Readable is not supposed to have an end method. Either way, fix the compile error by papering over it.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@ofrobots ofrobots merged commit def5a1f into googleapis:master Oct 30, 2018
@ofrobots ofrobots deleted the fix-compilation branch October 30, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofrobots @JustinBeckwith @googlebot