Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware): tweak the middleware api #291

Merged
merged 3 commits into from
Oct 31, 2018
Merged

fix(middleware): tweak the middleware api #291

merged 3 commits into from
Oct 31, 2018

Conversation

ofrobots
Copy link
Contributor

  • Child suffix is not necessary.
  • Make emitRequestLog optional. Make it control finish tracking.

@ofrobots
fix(middleware): tweak the middleware api
85947d8 
* Child suffix is not necessary.
* Make emitRequestLog optional. Make it control finish tracking.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@kjin kjin self-requested a review October 30, 2018 22:38
kjin
kjin approved these changes Oct 30, 2018
View reviewed changes
src/middleware/express/make-middleware.ts Outdated Show resolved Hide resolved
@kjin @ofrobots
Update src/middleware/express/make-middleware.ts
a0aa45d 
Co-Authored-By: ofrobots <ofrobots@google.com>
@codecov
Copy link

codecov bot commented Oct 31, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2c1c8dc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #291   +/-   ##
=========================================
  Coverage          ?   92.31%           
=========================================
  Files             ?       14           
  Lines             ?      638           
  Branches          ?       61           
=========================================
  Hits              ?      589           
  Misses            ?       35           
  Partials          ?       14
Impacted Files Coverage Δ
src/middleware/express/make-middleware.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1c8dc...4d557d5. Read the comment docs.

@ofrobots ofrobots merged commit c41db2f into googleapis:master Oct 31, 2018
@ofrobots ofrobots deleted the tweak-middleware-api branch October 31, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjin kjin kjin approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofrobots @kjin @googlebot