Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadata): include zone on GAE descriptor #298

Merged
merged 3 commits into from
Nov 2, 2018
Merged

fix(metadata): include zone on GAE descriptor #298

merged 3 commits into from
Nov 2, 2018

Conversation

ofrobots
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2018
@codecov
Copy link

codecov bot commented Oct 31, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3ac69bb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #298   +/-   ##
=========================================
  Coverage          ?   92.23%           
=========================================
  Files             ?       14           
  Lines             ?      644           
  Branches          ?       57           
=========================================
  Hits              ?      594           
  Misses            ?       36           
  Partials          ?       14
Impacted Files Coverage Δ
src/metadata.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac69bb...c6abdc4. Read the comment docs.

JustinBeckwith
JustinBeckwith approved these changes Nov 1, 2018
View reviewed changes
src/metadata.ts Outdated Show resolved Hide resolved
@ofrobots ofrobots mentioned this pull request Nov 1, 2018
Closed
@JustinBeckwith JustinBeckwith merged commit 0fe56e8 into googleapis:master Nov 2, 2018
@ofrobots ofrobots deleted the gae-zone branch November 2, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofrobots @JustinBeckwith @googlebot