Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor (typescript): noImplilcitAny #408

Merged
merged 2 commits into from
Mar 1, 2019
Merged

refactor (typescript): noImplilcitAny #408

merged 2 commits into from
Mar 1, 2019

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Mar 1, 2019

Fixes #264

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2019
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 1, 2019
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files          14       14           
  Lines         631      631           
  Branches       34       34           
=======================================
  Hits          571      571           
  Misses         42       42           
  Partials       18       18
Impacted Files Coverage Δ
src/index.ts 99.45% <100%> (ø) ⬆️
src/sink.ts 96.42% <100%> (-0.13%) ⬇️
src/log.ts 80.23% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f881ec...828d823. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 1, 2019 •
edited
Loading

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files          14       14           
  Lines         631      631           
  Branches       34       34           
=======================================
  Hits          571      571           
  Misses         42       42           
  Partials       18       18
Impacted Files Coverage Δ
src/index.ts 99.45% <100%> (ø) ⬆️
src/sink.ts 96.42% <100%> (-0.13%) ⬇️
src/log.ts 80.23% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f881ec...828d823. Read the comment docs.

JustinBeckwith
JustinBeckwith approved these changes Mar 1, 2019
View reviewed changes
src/index.ts
import * as is from 'is';
import * as request from 'request';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is types only... right?

@JustinBeckwith JustinBeckwith merged commit 75a70e5 into googleapis:master Mar 1, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AVaksman @JustinBeckwith @googlebot @kokoro-team