fix: only apply logName to filter when not already present #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 18 18
Lines 12985 12985
Branches 398 415 +17
=======================================
Hits 12776 12776
Misses 207 207
Partials 2 2
Continue to review full report at Codecov.
|
bcoe
approved these changes
Dec 2, 2020
bcoe
added
kokoro:force-run
freelerobot
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #943
This corrects an issue I discovered while researching #943. For convenience, we have
log.getEntries()add a filter to the provided query, filling in the logName for the user. However, if the query already had a filter with the logName included, it would duplicate the filter condition (logName=my-log AND logName=my-log AND ...).This scenario arises anytime the user calls "log.getEntries()" where there are enough results to warrant auto-pagination.