Skip to content

Commit

Permalink
build: only check --engine-strict for production deps
Browse files Browse the repository at this point in the history
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Thu Oct 15 17:40:52 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5451633881133e5573cc271a18e73b18caca8b1b
Source-Link: googleapis/synthtool@5451633
  • Loading branch information
yoshi-automation committed Oct 16, 2020
1 parent 54310a7 commit 254a460
Show file tree
Hide file tree
Showing 2 changed files with 78 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ jobs:
with:
node-version: ${{ matrix.node }}
- run: node --version
- run: npm install --engine-strict
# The first installation step ensures that all of our production
# dependencies work on the given Node.js version, this helps us find
# dependencies that don't match our engines field:
- run: npm install --production --engine-strict
- run: npm install
- run: npm test
- name: coverage
uses: codecov/codecov-action@v1
Expand Down
75 changes: 73 additions & 2 deletions synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-pubsub.git",
"sha": "f0c45105c8a07c5814418cc83414494e594d4515"
"sha": "54310a771b4b39c896f62fc18aea040cc42bfcd7"
}
},
{
Expand All @@ -19,7 +19,7 @@
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "27e0e916cbfdb3d5ff6639b686cc04f78a0b0386"
"sha": "5451633881133e5573cc271a18e73b18caca8b1b"
}
}
],
Expand All @@ -33,5 +33,76 @@
"generator": "bazel"
}
}
],
"generatedFiles": [
".eslintignore",
".eslintrc.json",
".gitattributes",
".github/ISSUE_TEMPLATE/bug_report.md",
".github/ISSUE_TEMPLATE/feature_request.md",
".github/ISSUE_TEMPLATE/support_request.md",
".github/PULL_REQUEST_TEMPLATE.md",
".github/release-please.yml",
".github/workflows/ci.yaml",
".gitignore",
".jsdoc.js",
".kokoro/.gitattributes",
".kokoro/common.cfg",
".kokoro/continuous/node10/common.cfg",
".kokoro/continuous/node10/docs.cfg",
".kokoro/continuous/node10/test.cfg",
".kokoro/continuous/node12/common.cfg",
".kokoro/continuous/node12/lint.cfg",
".kokoro/continuous/node12/samples-test.cfg",
".kokoro/continuous/node12/system-test.cfg",
".kokoro/continuous/node12/test.cfg",
".kokoro/docs.sh",
".kokoro/lint.sh",
".kokoro/populate-secrets.sh",
".kokoro/presubmit/node10/common.cfg",
".kokoro/presubmit/node12/common.cfg",
".kokoro/presubmit/node12/samples-test.cfg",
".kokoro/presubmit/node12/system-test.cfg",
".kokoro/presubmit/node12/test.cfg",
".kokoro/publish.sh",
".kokoro/release/docs-devsite.cfg",
".kokoro/release/docs-devsite.sh",
".kokoro/release/docs.cfg",
".kokoro/release/docs.sh",
".kokoro/release/publish.cfg",
".kokoro/samples-test.sh",
".kokoro/system-test.sh",
".kokoro/test.bat",
".kokoro/test.sh",
".kokoro/trampoline.sh",
".kokoro/trampoline_v2.sh",
".mocharc.js",
".nycrc",
".prettierignore",
".prettierrc.js",
".trampolinerc",
"CODE_OF_CONDUCT.md",
"CONTRIBUTING.md",
"LICENSE",
"README.md",
"api-extractor.json",
"linkinator.config.json",
"protos/google/pubsub/v1/pubsub.proto",
"protos/protos.d.ts",
"protos/protos.js",
"protos/protos.json",
"renovate.json",
"samples/README.md",
"src/v1/index.ts",
"src/v1/publisher_client.ts",
"src/v1/publisher_client_config.json",
"src/v1/publisher_proto_list.json",
"src/v1/subscriber_client.ts",
"src/v1/subscriber_client_config.json",
"src/v1/subscriber_proto_list.json",
"test/gapic_publisher_v1.ts",
"test/gapic_subscriber_v1.ts",
"tsconfig.json",
"webpack.config.js"
]
}

0 comments on commit 254a460

Please sign in to comment.