Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata key contains illegal characters #667

Closed
pjm17971 opened this issue Jun 24, 2019 · 5 comments
Closed

Metadata key contains illegal characters #667

pjm17971 opened this issue Jun 24, 2019 · 5 comments
Assignees
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. status: duplicate Duplicate. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@pjm17971
Copy link

Seeing many of these per day:

Error: Failed to "modifyAckDeadline" for 202 message(s).
Reason: Metadata key "@" contains illegal characters

Maybe related:
googleapis/nodejs-datastore#415

Environment details

  • OS: GKE
  • Node.js version: 10.10.x
  • npm version:
  • @google-cloud/pubsub version: 0.30.0
@callmehiphop callmehiphop added status: duplicate Duplicate. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 24, 2019
@callmehiphop
Copy link
Contributor

@pjm17971 0.30.0 made the switch to grpc-js, so it likely is a duplicate of googleapis/nodejs-datastore#415. You might consider pinning to 0.29.0 until we get this sorted out.

FYI @sduskis @alexander-fenster

I'm going to close this out, but I would suggest subscribing to the aforementioned Datastore issue for updates.

@pjm17971
Copy link
Author

@callmehiphop we've rolled back to 0.29.0. Just wanted to make sure you guys were aware that the grpc-js library change affected the pubsub client too. But I guess you're on it. Thanks!

alexander-fenster added a commit to googleapis/gax-nodejs that referenced this issue Jul 12, 2019
This fix includes grpc/grpc-node#962 which is a work around for a bad metadata keys problem that many customer see across several libraries (googleapis/nodejs-datastore#415, googleapis/nodejs-logging#527, googleapis/nodejs-pubsub#667 are just a few).
JustinBeckwith pushed a commit to googleapis/gax-nodejs that referenced this issue Jul 12, 2019
This fix includes grpc/grpc-node#962 which is a work around for a bad metadata keys problem that many customer see across several libraries (googleapis/nodejs-datastore#415, googleapis/nodejs-logging#527, googleapis/nodejs-pubsub#667 are just a few).
@alexander-fenster
Copy link
Contributor

Hi @pjm17971,

We have released google-gax v1.1.5 that pulls @grpc/grpc-js v0.5.2 in which the invalid headers (that are coming from Node.js http2 module) are printed in a warning, but do not throw exception. Please upgrade your dependencies, it should fix the problem for you.

Thanks!

@mahaben
Copy link

mahaben commented Oct 2, 2019

Hi @alexander-fenster,

We still have the error Metadata key "a" contains illegal characters. We use @google-cloud/pubsub version: 1.0.0

Any idea?

Thanks,

@alexander-fenster
Copy link
Contributor

Hi @mahaben,

This error comes from Node.js http2 stack (nodejs/node#28632) and we don't have any solution at this moment, but we made sure we only print a warning and not an error. Make sure you update your dependencies.

npm ls @grpc/grpc-js

Starting from @grpc/grpc-js v0.5.2 this error is changed to warning so it should not crash your code.

We keep trying to catch and debug it, but since it's something happening in Node.js core, it might take more time.

@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. status: duplicate Duplicate. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants