Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloud-rad): move comments for TSDoc #1423

Merged
merged 3 commits into from
Nov 8, 2021
Merged

fix(cloud-rad): move comments for TSDoc #1423

merged 3 commits into from
Nov 8, 2021

Commits on Nov 8, 2021

  1. fix(cloud-rad): move comments for TSDoc 

    As we move our ref docs to cloud.google.com, we rely on TSDoc rather JSDoc.

TSDoc expects comments before the first overloaded function, we
currently have those on the last function. Those comments don't make
it into the d.ts files. We need to move comments to the first
overloaded function rather than the last one.

Internally b/190631834

Script used: https://github.com/fhinkel/cloud-rad-script/blob/main/moveComments.js
    @fhinkel
    fhinkel committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    ca50ccd View commit details
    Browse the repository at this point in the history

  2. Revert "fix(cloud-rad): move comments for TSDoc" 

    This reverts commit ca50ccd.
    @fhinkel
    fhinkel committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    29475bd View commit details
    Browse the repository at this point in the history

  3. Fix promisifyAll deletion

    @fhinkel
    fhinkel committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    eaf9435 View commit details
    Browse the repository at this point in the history