Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: convert to typescript #923
build!: convert to typescript #923
Changes from 138 commits
7276eca
2af5c35
7080c54
e8206af
2f32e34
c848fe7
93d35f1
7e2f1dc
a4e8f90
9d7e28a
ffa02bf
f42a1e0
153e188
b588e0b
9d38a6e
bf85031
ce7afdd
6d44cfe
6d91c8b
df1138c
fb8c091
15369fe
fa27b00
89342b3
701dbf3
870625f
2ce0c77
289ff7b
95084e0
e266a70
84028a9
aec31ce
677d82e
30cb418
be05487
ae72f6a
05976a6
1671f8c
a6980b3
266dfc0
3cf361d
de395f0
044f3c7
5b2ebf9
7518122
3a53b29
d51def6
75aaed5
828bf65
b27259c
b393ddc
3bc88ca
28e8668
9210fc0
fac8a82
7c08ac0
1dc4473
7672fd6
d852b85
e8050ce
e552791
8738c36
3c9d28d
834c884
dacb6df
e8f13b9
ba941fd
fce0b35
c5ebfc8
a7279ff
c3c1323
1ead50a
6195092
90e0f34
8633649
7a953cc
43fe86a
1843fca
132e656
11cff46
a59cb12
eb0b9be
2441b03
42bff9e
7303555
309133f
d0869af
df122db
7ca37e5
26467cf
a5d14fc
a1360f2
2362a3a
96b7a49
18df358
f357758
b51a4e1
b15104b
66280a4
6ebe457
b5606ad
507ebb3
af0ea07
6ca216a
f865604
947981d
6af2b9a
9e0624a
1ada358
e6ceb77
509336d
fbeb58d
60c5a24
f5f6881
ad14631
b02388a
576a131
69c6ed1
07c9493
bc1b405
8349c38
e48295c
5e48955
614f3c4
0a14591
e3d12fc
74c52d3
1143170
9079230
af0230e
6135301
9778571
0cfc0a1
49c7d06
bc476b9
b4d598e
a167a7a
03f454f
4acc3e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do still want
.vscode
(that's not getting checked in, right?) and**/package-lock.json
, because the samples install their ownnode_modules
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will put it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feywind synthtool remove
.vscode
and**/package-lock.json
automaticallyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-fenster Does this synthtool change seem right? Maybe we're excluding
.vscode
and**/package-lock.json
elsewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcoe what do you think? It might make sense to exclude
.vscode
and nested lockfiles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
"typescript": "^3.8.3"
as we do for other libraries?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussion with @feywind, upgrade typescript
^3.8.3
will happen when pubsub is ready for deprecate Node 8 and upgrade gts@2.0.0.