Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix: make request optional in all cases #61

Merged
merged 4 commits into from
Jun 25, 2021
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 44 additions & 30 deletions src/v1/service_manager_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ export class ServiceManagerClient {
// -- Service calls --
// -------------------
getService(
request: protos.google.api.servicemanagement.v1.IGetServiceRequest,
request?: protos.google.api.servicemanagement.v1.IGetServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -466,7 +466,7 @@ export class ServiceManagerClient {
* const [response] = await client.getService(request);
*/
getService(
request: protos.google.api.servicemanagement.v1.IGetServiceRequest,
request?: protos.google.api.servicemanagement.v1.IGetServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -509,7 +509,7 @@ export class ServiceManagerClient {
return this.innerApiCalls.getService(request, options, callback);
}
getServiceConfig(
request: protos.google.api.servicemanagement.v1.IGetServiceConfigRequest,
request?: protos.google.api.servicemanagement.v1.IGetServiceConfigRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -569,7 +569,7 @@ export class ServiceManagerClient {
* const [response] = await client.getServiceConfig(request);
*/
getServiceConfig(
request: protos.google.api.servicemanagement.v1.IGetServiceConfigRequest,
request?: protos.google.api.servicemanagement.v1.IGetServiceConfigRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -615,7 +615,7 @@ export class ServiceManagerClient {
return this.innerApiCalls.getServiceConfig(request, options, callback);
}
createServiceConfig(
request: protos.google.api.servicemanagement.v1.ICreateServiceConfigRequest,
request?: protos.google.api.servicemanagement.v1.ICreateServiceConfigRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -676,7 +676,7 @@ export class ServiceManagerClient {
* const [response] = await client.createServiceConfig(request);
*/
createServiceConfig(
request: protos.google.api.servicemanagement.v1.ICreateServiceConfigRequest,
request?: protos.google.api.servicemanagement.v1.ICreateServiceConfigRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -722,7 +722,7 @@ export class ServiceManagerClient {
return this.innerApiCalls.createServiceConfig(request, options, callback);
}
getServiceRollout(
request: protos.google.api.servicemanagement.v1.IGetServiceRolloutRequest,
request?: protos.google.api.servicemanagement.v1.IGetServiceRolloutRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -776,7 +776,7 @@ export class ServiceManagerClient {
* const [response] = await client.getServiceRollout(request);
*/
getServiceRollout(
request: protos.google.api.servicemanagement.v1.IGetServiceRolloutRequest,
request?: protos.google.api.servicemanagement.v1.IGetServiceRolloutRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -822,7 +822,7 @@ export class ServiceManagerClient {
return this.innerApiCalls.getServiceRollout(request, options, callback);
}
generateConfigReport(
request: protos.google.api.servicemanagement.v1.IGenerateConfigReportRequest,
request?: protos.google.api.servicemanagement.v1.IGenerateConfigReportRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -893,7 +893,7 @@ export class ServiceManagerClient {
* const [response] = await client.generateConfigReport(request);
*/
generateConfigReport(
request: protos.google.api.servicemanagement.v1.IGenerateConfigReportRequest,
request?: protos.google.api.servicemanagement.v1.IGenerateConfigReportRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -934,7 +934,7 @@ export class ServiceManagerClient {
}

createService(
request: protos.google.api.servicemanagement.v1.ICreateServiceRequest,
request?: protos.google.api.servicemanagement.v1.ICreateServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -993,7 +993,7 @@ export class ServiceManagerClient {
* const [response] = await operation.promise();
*/
createService(
request: protos.google.api.servicemanagement.v1.ICreateServiceRequest,
request?: protos.google.api.servicemanagement.v1.ICreateServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1072,7 +1072,7 @@ export class ServiceManagerClient {
>;
}
deleteService(
request: protos.google.api.servicemanagement.v1.IDeleteServiceRequest,
request?: protos.google.api.servicemanagement.v1.IDeleteServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1134,7 +1134,7 @@ export class ServiceManagerClient {
* const [response] = await operation.promise();
*/
deleteService(
request: protos.google.api.servicemanagement.v1.IDeleteServiceRequest,
request?: protos.google.api.servicemanagement.v1.IDeleteServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1219,7 +1219,7 @@ export class ServiceManagerClient {
>;
}
undeleteService(
request: protos.google.api.servicemanagement.v1.IUndeleteServiceRequest,
request?: protos.google.api.servicemanagement.v1.IUndeleteServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1281,7 +1281,7 @@ export class ServiceManagerClient {
* const [response] = await operation.promise();
*/
undeleteService(
request: protos.google.api.servicemanagement.v1.IUndeleteServiceRequest,
request?: protos.google.api.servicemanagement.v1.IUndeleteServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1366,7 +1366,7 @@ export class ServiceManagerClient {
>;
}
submitConfigSource(
request: protos.google.api.servicemanagement.v1.ISubmitConfigSourceRequest,
request?: protos.google.api.servicemanagement.v1.ISubmitConfigSourceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1441,7 +1441,7 @@ export class ServiceManagerClient {
* const [response] = await operation.promise();
*/
submitConfigSource(
request: protos.google.api.servicemanagement.v1.ISubmitConfigSourceRequest,
request?: protos.google.api.servicemanagement.v1.ISubmitConfigSourceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1526,7 +1526,7 @@ export class ServiceManagerClient {
>;
}
createServiceRollout(
request: protos.google.api.servicemanagement.v1.ICreateServiceRolloutRequest,
request?: protos.google.api.servicemanagement.v1.ICreateServiceRolloutRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1598,7 +1598,7 @@ export class ServiceManagerClient {
* const [response] = await operation.promise();
*/
createServiceRollout(
request: protos.google.api.servicemanagement.v1.ICreateServiceRolloutRequest,
request?: protos.google.api.servicemanagement.v1.ICreateServiceRolloutRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1683,7 +1683,7 @@ export class ServiceManagerClient {
>;
}
enableService(
request: protos.google.api.servicemanagement.v1.IEnableServiceRequest,
request?: protos.google.api.servicemanagement.v1.IEnableServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1753,9 +1753,10 @@ export class ServiceManagerClient {
* @example
* const [operation] = await client.enableService(request);
* const [response] = await operation.promise();
* @deprecated EnableService is deprecated and may be removed in a future version.
*/
enableService(
request: protos.google.api.servicemanagement.v1.IEnableServiceRequest,
request?: protos.google.api.servicemanagement.v1.IEnableServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1800,6 +1801,11 @@ export class ServiceManagerClient {
service_name: request.serviceName || '',
});
this.initialize();
gax.warn(
'DEP$ServiceManager-$EnableService',
'EnableService is deprecated and may be removed in a future version.',
'DeprecationWarning'
);
return this.innerApiCalls.enableService(request, options, callback);
}
/**
Expand All @@ -1816,6 +1822,7 @@ export class ServiceManagerClient {
* console.log(decodedOperation.result);
* console.log(decodedOperation.done);
* console.log(decodedOperation.metadata);
* @deprecated EnableService is deprecated and may be removed in a future version.
*/
async checkEnableServiceProgress(
name: string
Expand All @@ -1840,7 +1847,7 @@ export class ServiceManagerClient {
>;
}
disableService(
request: protos.google.api.servicemanagement.v1.IDisableServiceRequest,
request?: protos.google.api.servicemanagement.v1.IDisableServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1909,9 +1916,10 @@ export class ServiceManagerClient {
* @example
* const [operation] = await client.disableService(request);
* const [response] = await operation.promise();
* @deprecated DisableService is deprecated and may be removed in a future version.
*/
disableService(
request: protos.google.api.servicemanagement.v1.IDisableServiceRequest,
request?: protos.google.api.servicemanagement.v1.IDisableServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1956,6 +1964,11 @@ export class ServiceManagerClient {
service_name: request.serviceName || '',
});
this.initialize();
gax.warn(
'DEP$ServiceManager-$DisableService',
'DisableService is deprecated and may be removed in a future version.',
'DeprecationWarning'
);
return this.innerApiCalls.disableService(request, options, callback);
}
/**
Expand All @@ -1972,6 +1985,7 @@ export class ServiceManagerClient {
* console.log(decodedOperation.result);
* console.log(decodedOperation.done);
* console.log(decodedOperation.metadata);
* @deprecated DisableService is deprecated and may be removed in a future version.
*/
async checkDisableServiceProgress(
name: string
Expand All @@ -1996,7 +2010,7 @@ export class ServiceManagerClient {
>;
}
listServices(
request: protos.google.api.servicemanagement.v1.IListServicesRequest,
request?: protos.google.api.servicemanagement.v1.IListServicesRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -2067,7 +2081,7 @@ export class ServiceManagerClient {
* for more details and examples.
*/
listServices(
request: protos.google.api.servicemanagement.v1.IListServicesRequest,
request?: protos.google.api.servicemanagement.v1.IListServicesRequest,
optionsOrCallback?:
| CallOptions
| PaginationCallback<
Expand Down Expand Up @@ -2201,7 +2215,7 @@ export class ServiceManagerClient {
) as AsyncIterable<protos.google.api.servicemanagement.v1.IManagedService>;
}
listServiceConfigs(
request: protos.google.api.servicemanagement.v1.IListServiceConfigsRequest,
request?: protos.google.api.servicemanagement.v1.IListServiceConfigsRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -2259,7 +2273,7 @@ export class ServiceManagerClient {
* for more details and examples.
*/
listServiceConfigs(
request: protos.google.api.servicemanagement.v1.IListServiceConfigsRequest,
request?: protos.google.api.servicemanagement.v1.IListServiceConfigsRequest,
optionsOrCallback?:
| CallOptions
| PaginationCallback<
Expand Down Expand Up @@ -2399,7 +2413,7 @@ export class ServiceManagerClient {
) as AsyncIterable<protos.google.api.IService>;
}
listServiceRollouts(
request: protos.google.api.servicemanagement.v1.IListServiceRolloutsRequest,
request?: protos.google.api.servicemanagement.v1.IListServiceRolloutsRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -2466,7 +2480,7 @@ export class ServiceManagerClient {
* for more details and examples.
*/
listServiceRollouts(
request: protos.google.api.servicemanagement.v1.IListServiceRolloutsRequest,
request?: protos.google.api.servicemanagement.v1.IListServiceRolloutsRequest,
optionsOrCallback?:
| CallOptions
| PaginationCallback<
Expand Down