fix(bucket): only disable resumable uploads for bucket.upload when in…

…specting the file size (fixes #1133)
googleapis · Apr 23, 2020 · 3948e91 · 3948e91
1 parent 5caaa0a
commit 3948e91
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/bucket.ts b/src/bucket.ts
@@ -3454,7 +3454,10 @@ class Bucket extends ServiceObject {
           return;
         }
 
-        options.resumable = fd.size > RESUMABLE_THRESHOLD;
+        if (fd.size <= RESUMABLE_THRESHOLD) {
+          // Only disable resumable uploads so createWriteStream still attempts them and falls back to simple upload.
+          options.resumable = false;
+        }
 
         upload();
       });