refactor: remove usage of async module (#702)

googleapis · May 9, 2019 · c94cc72 · c94cc72
1 parent 42937a8
commit c94cc72
Show file tree

Hide file tree

Showing 3 changed files with 304 additions and 587 deletions.
diff --git a/package.json b/package.json
@@ -54,7 +54,6 @@
     "@google-cloud/paginator": "^1.0.0",
     "@google-cloud/promisify": "^1.0.0",
     "arrify": "^2.0.0",
-    "async": "^2.0.1",
     "compressible": "^2.0.12",
     "concat-stream": "^2.0.0",
     "date-and-time": "^0.6.3",
@@ -107,6 +106,7 @@
     "node-fetch": "^2.2.0",
     "normalize-newline": "^3.0.0",
     "nyc": "^14.0.0",
+    "p-limit": "^2.2.0",
     "power-assert": "^1.4.4",
     "prettier": "^1.7.0",
     "proxyquire": "^2.0.0",

diff --git a/src/bucket.ts b/src/bucket.ts
@@ -1099,7 +1099,7 @@ class Bucket extends ServiceObject {
   combine(
     sources: string[] | File[],
     destination: string | File,
-    options: CombineOptions
+    options?: CombineOptions
   ): Promise<CombineResponse>;
   combine(
     sources: string[] | File[],
@@ -2773,7 +2773,7 @@ class Bucket extends ServiceObject {
 
   setStorageClass(
     storageClass: string,
-    options: SetBucketStorageClassOptions
+    options?: SetBucketStorageClassOptions
   ): Promise<SetBucketMetadataResponse>;
   setStorageClass(
     storageClass: string,
@@ -2827,7 +2827,7 @@ class Bucket extends ServiceObject {
    */
   setStorageClass(
     storageClass: string,
-    optionsOrCallback:
+    optionsOrCallback?:
       | SetBucketStorageClassOptions
       | SetBucketStorageClassCallback,
     callback?: SetBucketStorageClassCallback