-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v4-policy): encode special characters #1169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 28, 2020
jkwlui
force-pushed
the
fix-encode-special-chars
branch
from
April 28, 2020 19:20
c5ad12a
to
4ab48b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1169 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 12 12
Lines 11440 11453 +13
Branches 589 590 +1
=======================================
+ Hits 11348 11361 +13
Misses 92 92
Continue to review full report at Codecov.
|
…js-storage into fix-encode-special-chars
stephenplusplus
approved these changes
May 1, 2020
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jul 30, 2021
Co-authored-by: Anthonios Partheniou <partheniou@google.com> Source-Link: googleapis/synthtool@df7fc1e Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:6245a5be4c0406d9b2f04f380d8b88ffe4655df3cdbb57626f8913e8d620f4dd
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
Co-authored-by: Anthonios Partheniou <partheniou@google.com> Source-Link: googleapis/synthtool@df7fc1e Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:6245a5be4c0406d9b2f04f380d8b88ffe4655df3cdbb57626f8913e8d620f4dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.stringify
doesn't encode special character to its unicode representationé
=>\u00e9
as is expected by signed policy.