Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: improve GetFilesResponse interface #2466

Merged
merged 5 commits into from
May 14, 2024
Merged

Fix: improve GetFilesResponse interface #2466

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5d8944
Fix: improve GetFilesResponse interface
olishevskii May 12, 2024
8c564bb
fix: Improve GetFilesResponse interface
olishevskii May 13, 2024
7352576
Fix: improve GetFilesResponse interface
olishevskii May 14, 2024
cc267b7
Fix: improve GetFilesResponse interface
olishevskii May 14, 2024
d463714
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ interface MetadataOptions {
ifMetagenerationNotMatch?: number | string;
}

export type GetFilesResponse = [File[], {}, unknown];
export type GetFilesResponse = [
File[],
(GetFilesOptions | {}) & Partial<Pick<GetFilesOptions, 'pageToken'>>,
unknown,
];
export interface GetFilesCallback {
(
err: Error | null,
Expand Down
Loading