This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: refactors person and face detection samples #370

Merged

telpirion merged 5 commits into master from detection-samples-refactor

Feb 13, 2020

Contributor

telpirion commented Feb 12, 2020

This changes the samples and tests for Video Intelligence face and person detection so that each has its own file.

The following region_tags are affected:

video_detect_faces_gcs_beta
video_detect_faces_beta
video_detect_person_gcs_beta
video_detect_person_beta

telpirion added 4 commits

February 12, 2020 11:00


          fix: adds spaces to region tags, other fixes

517d33e


          fix: refactors people and face detection into separate files

c614dfd


          fix: removes unneeded files

dc46189


          Resolving conflicts from master

474878e

googlebot added the cla: yes label


          fix: switches copyright lines in samples

a5bb43c

telpirion requested review from bcoe and nnegrey

February 12, 2020 21:26

bcoe approved these changes

View reviewed changes

Contributor

bcoe left a comment

this looks reasonable to me, with the caveat that we need to make sure to update the region tags on cloud.google.com.

Contributor Author

telpirion commented Feb 13, 2020

Good point. I've made necessary arrangements to have the documentation updated.

telpirion merged commit eb9b400 into master

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 2.7.0

66663f6

🤖 I have created a release \*beep\* \*boop\* 
---
## [2.7.0](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v2.6.5...v2.7.0) (2020-02-13)


### Features

* face and person detection samples ([#362](https://www.github.com/googleapis/nodejs-video-intelligence/issues/362)) ([cff2f36](https://www.github.com/googleapis/nodejs-video-intelligence/commit/cff2f36a4e6294908a4e26587ed840c1ec1b03f8))


### Bug Fixes

* adds spaces to region tags, other fixes ([#369](https://www.github.com/googleapis/nodejs-video-intelligence/issues/369)) ([2b6943e](https://www.github.com/googleapis/nodejs-video-intelligence/commit/2b6943ee0685761a0076c7b8023eed4f12f93d64))
* fixes face and people detection region tags ([#367](https://www.github.com/googleapis/nodejs-video-intelligence/issues/367)) ([ab039b5](https://www.github.com/googleapis/nodejs-video-intelligence/commit/ab039b56b3bea27edf93c4db7c97241599d38419))
* refactors person and face detection samples into separate files ([#370](https://www.github.com/googleapis/nodejs-video-intelligence/issues/370)) ([eb9b400](https://www.github.com/googleapis/nodejs-video-intelligence/commit/eb9b400c24bdf306d8263ec402922b3235754034))
* updates README file with correct links ([#371](https://www.github.com/googleapis/nodejs-video-intelligence/issues/371)) ([fb2701a](https://www.github.com/googleapis/nodejs-video-intelligence/commit/fb2701a81c7476ef06ab279a8d4572f006abe831))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels