Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: person detection samples to GA #504

Merged
merged 4 commits into from
Dec 3, 2020
Merged

feat: person detection samples to GA #504

merged 4 commits into from
Dec 3, 2020

Conversation

telpirion
Copy link
Contributor

This PR does the following:

  • Updates the person detection samples to use Video Intelligence v1.
  • Changes the file names from underscores to hyphens.
  • Renames the region tags to video_detect_person_gcs, video_detect_person

@telpirion telpirion requested review from a team as code owners December 3, 2020 00:50
@snippet-bot
Copy link

snippet-bot bot commented Dec 3, 2020

Here is the summary of changes.

You added 2 region tags.
You deleted 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@product-auto-label product-auto-label bot added api: videointelligence Issues related to the googleapis/nodejs-video-intelligence API. samples Issues that are directly related to samples. labels Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #504 (85c6083) into master (edc0aa2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files          14       14           
  Lines        3054     3054           
  Branches      172      178    +6     
=======================================
  Hits         2887     2887           
  Misses        161      161           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc0aa2...85c6083. Read the comment docs.

@telpirion telpirion requested review from bcoe and sofisl December 3, 2020 00:53
@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: videointelligence Issues related to the googleapis/nodejs-video-intelligence API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants