Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Commit

Permalink
docs: updates comments in protos
Browse files Browse the repository at this point in the history
  • Loading branch information
yoshi-automation authored and bcoe committed Sep 13, 2019
1 parent bc9fb65 commit 4b8f23b
Show file tree
Hide file tree
Showing 9 changed files with 39 additions and 45 deletions.
12 changes: 6 additions & 6 deletions protos/google/cloud/vision/v1/product_search.proto
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ message ProductSearchParams {
string product_set = 6;

// The list of product categories to search in. Currently, we only consider
// the first category, and either "homegoods-v2", "apparel-v2", or "toys-v2"
// should be specified. The legacy categories "homegoods", "apparel", and
// "toys" are still supported but will be deprecated. For new products, please
// use "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
// accuracy. It is recommended to migrate existing products to these
// categories as well.
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
// "packagedgoods-v1", or "general-v1" should be specified. The legacy
// categories "homegoods", "apparel", and "toys" are still supported but will
// be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
// or "toys-v2" for better product search accuracy. It is recommended to
// migrate existing products to these categories as well.
repeated string product_categories = 7;

// The filtering expression. This can be used to restrict search results based
Expand Down
6 changes: 3 additions & 3 deletions protos/google/cloud/vision/v1/product_search_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,9 @@ message Product {
string description = 3;

// The category for the product identified by the reference image. This should
// be either "homegoods-v2", "apparel-v2", or "toys-v2". The legacy categories
// "homegoods", "apparel", and "toys" are still supported, but these should
// not be used for new products.
// be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
// "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
// still supported, but these should not be used for new products.
//
// This field is immutable.
string product_category = 4;
Expand Down
12 changes: 6 additions & 6 deletions protos/google/cloud/vision/v1p4beta1/product_search.proto
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ message ProductSearchParams {
string product_set = 6;

// The list of product categories to search in. Currently, we only consider
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", or
// "packagedgoods-v1" should be specified. The legacy categories "homegoods",
// "apparel", and "toys" are still supported but will be deprecated. For new
// products, please use "homegoods-v2", "apparel-v2", or "toys-v2" for better
// product search accuracy. It is recommended to migrate existing products to
// these categories as well.
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
// "packagedgoods-v1", or "general-v1" should be specified. The legacy
// categories "homegoods", "apparel", and "toys" are still supported but will
// be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
// or "toys-v2" for better product search accuracy. It is recommended to
// migrate existing products to these categories as well.
repeated string product_categories = 7;

// The filtering expression. This can be used to restrict search results based
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,9 @@ message Product {
string description = 3;

// The category for the product identified by the reference image. This should
// be either "homegoods-v2", "apparel-v2", "toys-v2", or "packagedgoods-v1".
// The legacy categories "homegoods", "apparel", and "toys" are still
// supported but will be deprecated. For new products, please use
// "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
// accuracy. It is recommended to migrate existing products to these
// categories as well.
// be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
// "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
// still supported, but these should not be used for new products.
//
// This field is immutable.
string product_category = 4;
Expand Down
12 changes: 6 additions & 6 deletions src/v1/doc/google/cloud/vision/v1/doc_product_search.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@
*
* @property {string[]} productCategories
* The list of product categories to search in. Currently, we only consider
* the first category, and either "homegoods-v2", "apparel-v2", or "toys-v2"
* should be specified. The legacy categories "homegoods", "apparel", and
* "toys" are still supported but will be deprecated. For new products, please
* use "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
* accuracy. It is recommended to migrate existing products to these
* categories as well.
* the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
* "packagedgoods-v1", or "general-v1" should be specified. The legacy
* categories "homegoods", "apparel", and "toys" are still supported but will
* be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
* or "toys-v2" for better product search accuracy. It is recommended to
* migrate existing products to these categories as well.
*
* @property {string} filter
* The filtering expression. This can be used to restrict search results based
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
*
* @property {string} productCategory
* The category for the product identified by the reference image. This should
* be either "homegoods-v2", "apparel-v2", or "toys-v2". The legacy categories
* "homegoods", "apparel", and "toys" are still supported, but these should
* not be used for new products.
* be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
* "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
* still supported, but these should not be used for new products.
*
* This field is immutable.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
*
* @property {string[]} productCategories
* The list of product categories to search in. Currently, we only consider
* the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", or
* "packagedgoods-v1" should be specified. The legacy categories "homegoods",
* "apparel", and "toys" are still supported but will be deprecated. For new
* products, please use "homegoods-v2", "apparel-v2", or "toys-v2" for better
* product search accuracy. It is recommended to migrate existing products to
* these categories as well.
* the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
* "packagedgoods-v1", or "general-v1" should be specified. The legacy
* categories "homegoods", "apparel", and "toys" are still supported but will
* be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
* or "toys-v2" for better product search accuracy. It is recommended to
* migrate existing products to these categories as well.
*
* @property {string} filter
* The filtering expression. This can be used to restrict search results based
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,9 @@
*
* @property {string} productCategory
* The category for the product identified by the reference image. This should
* be either "homegoods-v2", "apparel-v2", "toys-v2", or "packagedgoods-v1".
* The legacy categories "homegoods", "apparel", and "toys" are still
* supported but will be deprecated. For new products, please use
* "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
* accuracy. It is recommended to migrate existing products to these
* categories as well.
* be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
* "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
* still supported, but these should not be used for new products.
*
* This field is immutable.
*
Expand Down
6 changes: 3 additions & 3 deletions synth.metadata
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"updateTime": "2019-09-06T11:26:58.194033Z",
"updateTime": "2019-09-13T11:29:41.331321Z",
"sources": [
{
"generator": {
Expand All @@ -12,8 +12,8 @@
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "960b76b1f0c46d12610088977d1129cc7405f3dc",
"internalRef": "267478864"
"sha": "dc88acb2ced136067d3ed2356b6a87ca7f017a96",
"internalRef": "268735517"
}
},
{
Expand Down

0 comments on commit 4b8f23b

Please sign in to comment.