fix: ignore case in system test assertions (#314)

googleapis · Jan 27, 2019 · 5460a85 · 5460a85
1 parent 767cff5
commit 5460a85
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/samples/resources/google.png b/samples/resources/google.png
diff --git a/samples/system-test/detect.test.js b/samples/system-test/detect.test.js
@@ -39,6 +39,7 @@ const files = [
   `city.jpg`,
   'pdf-ocr.pdf',
   'duck_and_truck.jpg',
+  'google.png',
 ].map(name => {
   return {
     name,
@@ -114,17 +115,17 @@ describe(`detect`, () => {
   });
 
   it(`should detect logos in a local file`, async () => {
-    const output = await exec(`${cmd} logos ${files[2].localPath}`);
+    const output = await exec(`${cmd} logos ${files[9].localPath}`);
     assert.match(output, /Logos:/);
-    assert.match(output, /Google/);
+    assert.match(output, /google/);
   });
 
   it(`should detect logos in a remote file`, async () => {
     const output = await exec(
-      `${cmd} logos-gcs ${bucketName} ${files[2].name}`
+      `${cmd} logos-gcs ${bucketName} ${files[9].name}`
     );
     assert.match(output, /Logos:/);
-    assert.match(output, /Google/);
+    assert.match(output, /google/);
   });
 
   it(`should detect properties in a local file`, async () => {

diff --git a/system-test/vision.js b/system-test/vision.js
@@ -66,22 +66,31 @@ describe('Vision', function() {
       'https://upload.wikimedia.org/wikipedia/commons/5/51/Google.png';
     return client.logoDetection(url).then(responses => {
       const response = responses[0];
-      assert.deepStrictEqual(response.logoAnnotations[0].description, 'Google');
+      assert.strictEqual(
+        response.logoAnnotations[0].description.toLowerCase(),
+        'google'
+      );
     });
   });
 
   it('should detect from a filename', () => {
     return client.logoDetection(IMAGES.logo).then(responses => {
       const response = responses[0];
-      assert.deepStrictEqual(response.logoAnnotations[0].description, 'Google');
+      assert.deepStrictEqual(
+        response.logoAnnotations[0].description.toLowerCase(),
+        'google'
+      );
     });
   });
 
   it('should detect from a Buffer', () => {
     const buffer = fs.readFileSync(IMAGES.logo);
     return client.logoDetection(buffer).then(responses => {
       const response = responses[0];
-      assert.deepStrictEqual(response.logoAnnotations[0].description, 'Google');
+      assert.deepStrictEqual(
+        response.logoAnnotations[0].description.toLowerCase(),
+        'google'
+      );
     });
   });