Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Allow multiple marshals. #9

Merged
merged 2 commits into from
Dec 27, 2018
Merged

[feat] Allow multiple marshals. #9

merged 2 commits into from
Dec 27, 2018

Conversation

lukesneeringer
Copy link
Contributor

This commit removes the "marshal as singleton" component, allowing
different marshals to exist in tandem. In general, each package
should likely use its own marshal.

Luke Sneeringer added 2 commits December 26, 2018 20:24
This commit removes the "marshal as singleton" component, allowing
different marshals to exist in tandem. In general, each package
should likely use its own marshal.
This is a syntax error in Python 3.5.
@codecov-io
Copy link

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     13    +1     
  Lines         537    553   +16     
  Branches       88     90    +2     
=====================================
+ Hits          537    553   +16
Impacted Files Coverage Δ
proto/marshal/rules/wrappers.py 100% <100%> (ø)
proto/marshal/rules/message.py 100% <100%> (ø)
proto/marshal/__init__.py 100% <100%> (ø)
proto/marshal/rules/dates.py 100% <100%> (ø)
proto/marshal/marshal.py 100% <100%> (ø) ⬆️
proto/__init__.py 100% <100%> (ø) ⬆️
proto/message.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33da283...95bc94e. Read the comment docs.

@lukesneeringer lukesneeringer merged commit 84c2c28 into master Dec 27, 2018
@lukesneeringer lukesneeringer deleted the refactor-marshal branch December 27, 2018 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants