feat: more performance optimizations #92
Merged
+27
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two big changes here are bypassing __init__ in a special case and directly setting instance attributes via reaching into self.__dict__. These are optimizations in a potential hot path that were isolated via exhaustive profiling and experimentation. Do not try this at home.
software-dov
requested review from
lukesneeringer,
crwilcox,
busunkim96 and
arithmetic1728
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 809 811 +2
Branches 136 136
=========================================
+ Hits 809 811 +2
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two big changes here are bypassing init in a special case and
directly setting instance attributes via reaching into self.dict.
These are optimizations in a potential hot path that were isolated via
exhaustive profiling and experimentation and save ~%16 in certain benchmarks.
Do not try this at home.