-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling response stream pre-fetch #30
Conversation
This seems like a reasonable approach. Before merging I would like to take a moment and make sure firestore is 'fixed' with the original change as well, just to make sure this isn't fixing the wrong thing :) |
Sounds good, let me know when you have info on that. :) |
@crwilcox Anything I can do to help this move forward? I accidentally introduced a dependency conflict with a new release of google-api-python-client |
+1, quite a few PubSub users are looking forward to the fix, too. |
Hi! Is there any ETA for having this merged? We're currently blocked on a bugfix for this in our servers. Thanks! |
@space55 @arithmetic1728 The new PubSub release that includes its part of this fix is on the way. |
Thanks! I'm excited! |
Closes #25.
This PR adds the ability to disable automatically pre-fetching the first item of a stream returned by
*-Stream
gRPC callables. This hook will be used in PubSub to fix the stalled stream issue, while also not affecting Firestore, since the default behavior is preserved.I realize the fix is far from ideal, but it's the least ugly among the approaches I tried, e.g. somehow passing the flag through
ResumableBidiRpc
(it's a messy rabbit hole). On the PubSub side monkeypatching the generated SubscriberClient will be needed, but it's a (relatively) clean one-liner:If/when we merge this, we should also release it, and then we can add
!= 1.17.0
to thegoogle-api-core
version pin in PubSub.PR checklist