Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify passing the arguments to OrderedDict in lexer #599

Closed
plamut opened this issue Apr 8, 2021 · 0 comments · Fixed by #598
Closed

Simplify passing the arguments to OrderedDict in lexer #599

plamut opened this issue Apr 8, 2021 · 0 comments · Fixed by #598
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: cleanup An internal cleanup or hygiene concern.

Comments

@plamut
Copy link
Contributor

plamut commented Apr 8, 2021

Token definitions in the custom parser for bigquery cell magic are passed as a list of (key, value) pairs, which results in extra two levels of indentation after formatting and additional noise (parentheses, quotes...).

Since we don't support Python 3.5 and below anymore, we can define the tokens as kwargs to OrderedDict. The kwargs ordered in Python 3.6+ is preserved (PEP 468).

@plamut plamut added the type: cleanup An internal cleanup or hygiene concern. label Apr 8, 2021
@plamut plamut self-assigned this Apr 8, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant