chore: cleanup intersphinx links #1035
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
reviewed
Oct 28, 2021
docs/conf.py
Outdated
| "proto-plus": ("https://proto-plus-python.readthedocs.io/en/latest/", None), | ||
| "protobuf": ("https://googleapis.dev/python/protobuf/latest/", None), | ||
| "pandas": ("http://pandas.pydata.org/pandas-docs/stable/", None), |
There was a problem hiding this comment.
(nit) Wasn't that changed to https to avoid an unnecessary redirect? I remember seeing this before recently.
There was a problem hiding this comment.
I remember that too. Maybe we did that in one of the other repos?
owlbot.py
Outdated
Comment on lines
35
to
36
| "proto-plus": ("https://proto-plus-python.readthedocs.io/en/latest/", None), | ||
| "protobuf": ("https://googleapis.dev/python/protobuf/latest/", None), |
There was a problem hiding this comment.
Didn't we say we want to keep these? Since we'll keep the legacy proto models around for import?
There was a problem hiding this comment.
It's redundant with the templates from the synthtool repo. I'd rather not add them here + add a line to remove the duplicates (line 59)
plamut
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕