Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove upper bound on packaging dependency #1440

Merged
merged 6 commits into from
Jan 13, 2023
Merged

deps: remove upper bound on packaging dependency #1440

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc13e09
deps: remove upper bound on packaging dependency
tswast Dec 13, 2022
11474fe
install prerelease version of packaging
tswast Dec 13, 2022
5d1de19
Merge branch 'main' into issue1435-remove-packaging-upper-bound
tswast Dec 14, 2022
8f543ab
Merge branch 'main' into issue1435-remove-packaging-upper-bound
parthea Jan 10, 2023
3ac8213
bump minimum packaging version
tswast Jan 13, 2023
dc13394
Merge branch 'main' into issue1435-remove-packaging-upper-bound
tswast Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,11 @@ def prerelease_deps(session):
"--upgrade",
"pandas",
)
session.install(
"--pre",
"--upgrade",
"git+https://github.com/pypa/packaging.git",
)

session.install(
"--pre",
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
# https://github.com/googleapis/google-cloud-python/issues/10566
"google-cloud-core >= 1.4.1, <3.0.0dev",
"google-resumable-media >= 0.6.0, < 3.0dev",
"packaging >= 14.3, <22.0.0dev",
"packaging >= 14.3",
"protobuf>=3.19.5,<5.0.0dev,!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5", # For the legacy proto-based types.
"python-dateutil >= 2.7.2, <3.0dev",
"requests >= 2.21.0, < 3.0.0dev",
Expand Down
1 change: 1 addition & 0 deletions testing/constraints-3.7.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ ipython==7.0.1
opentelemetry-api==1.1.0
opentelemetry-instrumentation==0.20b0
opentelemetry-sdk==1.1.0
packaging==14.3
Copy link

@hirosassa hirosassa Jan 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast It looks that the problem you suggest comes from this version constraint.

v14.3 of packaging has no major attribute:
https://github.com/pypa/packaging/blob/14.3/packaging/version.py#L268-L280

I think we need to update the lower bound, too.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major is added since v20.0.

ref: https://github.com/pypa/packaging/releases/tag/20.0

pandas==1.1.0
proto-plus==1.22.0
protobuf==3.19.5
Expand Down