-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support and tests for struct fields #146
Conversation
Just a thought - if I understand correctly, this fix will only work in Python 3 due to the new If so, we might want to wait with this for a bit, since a green light was given to start transitioning the libraries to the new code generator, which also implies dropping Python 2 support. Before this transition one final Python 2 compatible release will be made, but since this fix only affects Python 3, we might want to wait for an extra week or two, and then merge a simplified version of it. |
It turned out there is still some work needed to transition the library to the new microgenerator (e.g. transitioning the dependencies first), which might take a while. Considering that, it's probably not worth waiting for it and getting the fix in sooner has value. I'll review this tomorrow and see if it's good to merge and include in the next (non-major) release. @HemangChothani It probably makes sense to conditionally bump the minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we now also have to bump the minimum pyarrow
version to 0.17.0
if python version >= 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this.
Don't mind the samples, #174 contains a fix for them.
…into bigquery_issue_21
…into bigquery_issue_21
@shollyman, @plamut I can't see any log for the failed |
On chat, I see that the |
@HemangChothani It looks like you have turned off commits from mainainers for this PR's branch, which means the automerge bot cannot "push the button" for you (nor can I). |
…into bigquery_issue_21
@tseaver I thnik that's my bad, can i merge this PR? |
@HemangChothani In principle yes, but in the meantime @busunkim96 closed all PRs. It might be because of the CI maintenance work or something, don't know yet. |
Fixes #21
python2
so add condition forvalueerror
which raised when python2 excecuted.