Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added an error message with column name when Series to pyarrow conver… #1622

Conversation

karkinissan
Copy link

…sion fails. Allows for easier debugging.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1621 🦕

@karkinissan karkinissan requested review from a team as code owners July 21, 2023 14:08
@google-cla
Copy link

google-cla bot commented Jul 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 21, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 21, 2023
@shollyman shollyman requested review from chalmerlowe and removed request for jainsahab August 16, 2023 19:54
@chalmerlowe
Copy link
Contributor

Do we have any evidence that this problem affects other conversions besides pyarrow.Array

Does a similar problem occur with:

  • pyarrow.ListArray
  • pyarrow.StructArray

If YES do we need to have similar error handling behavior on lines 376-379?

@karkinissan
Copy link
Author

Good point. I would say yes. The Try block should cover lines 376 to 380.
I am not going to update the pull request for this. I have no experience creating those for large repos like this.
So please feel free to create one yourself. : )

@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@chalmerlowe chalmerlowe changed the title Added an error message with column name when Series to pyarrow conver… fix: Added an error message with column name when Series to pyarrow conver… Mar 7, 2024
@chalmerlowe
Copy link
Contributor

The content of this PR has been incorporated in the following PR: #1836
Thanks for kicking off this effort. Much appreciated.
The other PR also includes verbiage to identify potential issues with ListArray and StructArray.
Closing this PR.

@chalmerlowe
Copy link
Contributor

Closed by the merger of #1836

@karkinissan
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow conversion errors do not indicate problematic dataframe column.
2 participants