-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Model.transform_columns
property
#1661
Merged
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9507821
added TransformColumns class + corresponding unit tests
9ef24fe
Merge branch 'main' into Salem
SalemJorden 209455a
Merge branch 'main' into Salem
SalemJorden 61eb437
TransformColumns: @property 'getters' and 'setters' + updated unit tests
4902ee4
changes based on code review notes
SalemJorden 0049688
changes based on code review
SalemJorden bcdee27
Updated args
SalemJorden 4976284
updated return type annotation,returning new sequence of TransformCol…
SalemJorden 43d4267
deleted unecesscary coverage file
SalemJorden 781c655
return a sequence of your new TransformColumn objects instead of a se…
SalemJorden 8a2a6fc
code review changes
SalemJorden 026cc4d
updated tests
SalemJorden 481dfb8
test restoration & returning Model instead of TransformColumn
SalemJorden 46f9843
code review changes
SalemJorden 56c5ef9
Merge branch 'main' into Salem
tswast 0cf4241
Update google/cloud/bigquery/model.py
tswast c9cacbe
pull from main branch
SalemJorden 56c7802
Update tests/unit/model/test_model.py
tswast 2aa8edf
address type and lint errors
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this return a sequence of your new TransformColumn objects instead of a sequence of dictionaries.