-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: consolidate PyarrowVersions helpers #1679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchin
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Oct 9, 2023
product-auto-label
bot
added
size: m
Pull request size is medium.
api: bigquery
Issues related to the googleapis/python-bigquery API.
labels
Oct 9, 2023
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: m
Pull request size is medium.
labels
Oct 9, 2023
Linchin
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Oct 9, 2023
tswast
reviewed
Oct 10, 2023
Linchin
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 11, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 11, 2023
Linchin
changed the title
chore: consolidate pyarrow helpers
chore: consolidate PyarrowVersions helpers
Oct 11, 2023
4 tasks
tswast
requested changes
Oct 13, 2023
After talking to @tswast more about the implementation details, I understood the context and requirements a bit more now:
|
Linchin
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 17, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 17, 2023
tswast
requested changes
Oct 17, 2023
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Tim Swast <swast@google.com>
tswast
approved these changes
Oct 18, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of solution for #1430
This PR cleans up the pyarrow version check related code and consolidate them in a single
_pyarrow_helpers.py
file.Items:
_pyarrow_helpers.py
_pyarrow_helpers.py
test_pyarrow_helpers.py
PyarrowVersions
methodsThank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Will create a separate PR for cleaning up BQStorageVersions.