Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AccessEntry API representation parsing #1682

Merged
merged 4 commits into from
Oct 19, 2023

Commits on Oct 13, 2023

  1. fix: AccessEntry API representation parsing

    Overriding the `AccessEntry#_properties` with a deep copy of the API resource overwrites the `role` property set in `AccessEntry.__init__` which isn't present in the resource if the `role` is set to `None`. This causes `AccessEntry`s generated from API representations to no longer evaluate to equal with equivalent `AccessEntry` resources instantiated through `AccessEntry.__init__`. The added unit test fails without the change and passes with the change.
    jonathan-ostrander committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ce36b9f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. build: formatting

    jonathan-ostrander committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    15153e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9bad956 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Configuration menu
    Copy the full SHA
    3ae5a83 View commit details
    Browse the repository at this point in the history