Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor version checks for pandas library #1711

Merged
merged 8 commits into from
Nov 7, 2023
Merged

chore: refactor version checks for pandas library #1711

merged 8 commits into from
Nov 7, 2023

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Nov 2, 2023

Builds off of #1699

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #769 🦕

@kiraksi kiraksi requested review from a team as code owners November 2, 2023 21:39
@kiraksi kiraksi requested a review from obada-ab November 2, 2023 21:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 2, 2023
@kiraksi kiraksi requested a review from tswast November 2, 2023 21:41
@kiraksi kiraksi removed request for obada-ab and tswast November 2, 2023 22:48
@Linchin
Copy link
Contributor

Linchin commented Nov 3, 2023

Thank you @kiraksi for opening your first PR! Looks like the mypy tests are failing:

nox > * mypy: failed
nox > * mypy_samples: failed

Please try to run the same nox sessions locally, and fix the errors (likely some format issues).

tswast
tswast requested changes Nov 6, 2023
View reviewed changes
google/cloud/bigquery/_versions_helpers.py Outdated Show resolved Hide resolved
google/cloud/bigquery/_versions_helpers.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
tests/unit/test__versions_helpers.py Outdated Show resolved Hide resolved
@kiraksi kiraksi requested review from chalmerlowe and tswast November 6, 2023 23:53
chalmerlowe
chalmerlowe approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Confirm with Tim regarding the is not None comment.

tswast
tswast approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kiraksi kiraksi merged commit afa9752 into googleapis:main Nov 7, 2023
4 checks passed
@kiraksi kiraksi deleted the refactor-version-checks-pandas branch November 7, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor version checks for pandas, pyarrow
4 participants
@kiraksi @Linchin @tswast @chalmerlowe