feat: Introduce compatibility with native namespace packages #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
parthea
force-pushed
the
migrate-to-native-namespace-packages
branch
3 times, most recently
from
695affd to
fbeb2b0
Compare
parthea
added
the
do not merge
|
Adding |
parthea
force-pushed
the
migrate-to-native-namespace-packages
branch
from
fbeb2b0 to
c9a0753
Compare
parthea
force-pushed
the
migrate-to-native-namespace-packages
branch
2 times, most recently
from
336a9dc to
e69ce81
Compare
parthea
force-pushed
the
migrate-to-native-namespace-packages
branch
from
e69ce81 to
df642b0
Compare
Merged
4 tasks
kiraksi
approved these changes
Nov 16, 2023
| google.joinpath("othermod.py").write_text("") | ||
| env = dict(os.environ, PYTHONPATH=str(tmp_path)) | ||
| cmd = [sys.executable, "-m", "google.othermod"] | ||
| subprocess.check_call(cmd, env=env) |
There was a problem hiding this comment.
Were you able to run this test with subprocess without specifying to do it in the shell? It wasn't able to find the tmp path without me specifying to run in the shell, which is the small edit I did in the other PR for this
This was referenced Nov 16, 2023
|
Superseded by #1726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to googleapis/google-auth-library-python#1205
Also see https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages
Fixes #313 🦕