Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates query to query and wait in samples/desktopapp/user_credentials.py #1787

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

DevStephanie
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@DevStephanie DevStephanie requested review from a team as code owners January 17, 2024 04:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 17, 2024
@kiraksi kiraksi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@kiraksi kiraksi requested review from tswast and removed request for m-strzelczyk and nayaknishant January 17, 2024 11:14
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@kiraksi
Copy link
Contributor

kiraksi commented Jan 17, 2024

Looks like you forgot to remove query_job.result() here as I believe query_and_wait returns the result itself, as the cause of your sample errors. Also Tim mentioned in my PR that he wanted to query_job to be renamed to result as well which may also be helpful to you here!

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@kiraksi kiraksi enabled auto-merge (squash) January 18, 2024 22:15
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@chalmerlowe chalmerlowe added the type: docs Improvement to the documentation for an API. label Jan 22, 2024
@kiraksi kiraksi added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2024
@kiraksi kiraksi added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2024
@kiraksi kiraksi merged commit 89f1299 into googleapis:main Jan 22, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: xs Pull request size is extra small. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants