-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: throw exception for data type mismatch for load_table_from_dataf… #1824
Conversation
Thanks for jumping on this so quickly. We will likely need at least one new test to test this path. |
I can add a unit test for this if you like |
a2285b6
to
d976c09
Compare
ba2ac46
to
06c357d
Compare
06c357d
to
3a16f37
Compare
3a16f37
to
2d42fc6
Compare
Unit test was failing as exception thrown in python 3.7 and 3.8 and higher version was different. changed the assertion to use regex and tested locally with both the version. Tests should pass now. |
@Gaurang033 I took various parts of each of them and have merged them into a single PR. So please don't devote any additional time to this PR. |
Closed by the merger of #1836 |
Fixes #1822