Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix flaky systest #232

Merged
merged 9 commits into from
Sep 2, 2020
Merged

tests: fix flaky systest #232

merged 9 commits into from
Sep 2, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #229

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2020
HemangChothani
HemangChothani commented Aug 18, 2020
View reviewed changes
tests/system.py Outdated Show resolved Hide resolved
@HemangChothani HemangChothani changed the title fix: test flakes fix: fix flakes Aug 18, 2020
@tseaver tseaver changed the title fix: fix flakes tests: fix flaky systest Aug 18, 2020
tseaver
tseaver suggested changes Aug 18, 2020
View reviewed changes
tests/system.py Outdated Show resolved Hide resolved
tseaver
tseaver reviewed Aug 19, 2020
View reviewed changes
tests/system.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 21, 2020
@plamut plamut requested a review from cguardia August 28, 2020 10:01
cguardia
cguardia approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the requested changes have been properly done. @tseaver, can you check again to see if you are satisfied with the changes?

@HemangChothani
Copy link
Contributor Author

@tseaver PTAL!

@tseaver tseaver merged commit a125160 into googleapis:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@cguardia cguardia cguardia approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'test_delete_dataset_delete_contents_true' systest flakes with 409
3 participants
@HemangChothani @tseaver @cguardia