Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: break job into multiple modules #361

Merged
merged 2 commits into from
Nov 4, 2020
Merged

refactor: break job into multiple modules #361

merged 2 commits into from
Nov 4, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 3, 2020 •
edited
Loading

Original paths are retained for backwards compatibility.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #358 🦕

@tswast
refactor: break job into multiple modules
ce147ef 
Original paths are retained for backwards compatibility.
@tswast tswast requested review from a team and steffnay November 3, 2020 19:36
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 3, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2020
@tswast
Copy link
Contributor Author

tswast commented Nov 3, 2020

I promise I only moved code between modules. No logic / behavior changes.

@tswast tswast mentioned this pull request Nov 3, 2020
Closed
4 tasks
@tswast
Copy link
Contributor Author

tswast commented Nov 3, 2020

I double checked that there are 339 tests for the job-related classes before and after this change. All are passing.

@tswast tswast mentioned this pull request Nov 3, 2020
Merged
4 tasks
shollyman
shollyman approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Is your editor happier with the smaller files?

@tswast
Copy link
Contributor Author

tswast commented Nov 4, 2020

Is your editor happier with the smaller files?

So much happier! No more random jjj characters in my files due to lag after hitting esc.

@tswast tswast merged commit 2849e56 into googleapis:master Nov 4, 2020
@tswast tswast deleted the issue358-refactor-job branch November 4, 2020 15:09
@meredithslota meredithslota mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: split job.py and test_job.py
2 participants
@tswast @shollyman