perf: don't fetch rows when waiting for query to finish #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are large result sets, fetching rows while waiting for the query to finish can cause the API to hang indefinitely. (This may be due to an interaction between connection timeout and API timeout.) This reverts commit 86f6a51 (googleapis#374).
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tswast
commented
Nov 24, 2020
| @@ -1630,6 +1630,40 @@ def test_iterate(self): | |||
|
|
|||
| api_request.assert_called_once_with(method="GET", path=path, query_params={}) | |||
|
|
|||
| def test_iterate_with_cached_first_page(self): | |||
There was a problem hiding this comment.
I add these tests to fix coverage.
Perhaps instead I should also be reverting the changes from #384 ?
There was a problem hiding this comment.
The alternative I'd consider is doing a flag-based feature, so users can turn on the latency changes (or flip default, and provide an opt-out while we diagnose these other cases).
shollyman
approved these changes
Nov 24, 2020
| @@ -1630,6 +1630,40 @@ def test_iterate(self): | |||
|
|
|||
| api_request.assert_called_once_with(method="GET", path=path, query_params={}) | |||
|
|
|||
| def test_iterate_with_cached_first_page(self): | |||
There was a problem hiding this comment.
The alternative I'd consider is doing a flag-based feature, so users can turn on the latency changes (or flip default, and provide an opt-out while we diagnose these other cases).
tswast
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are large result sets, fetching rows while waiting for the
query to finish can cause the API to hang indefinitely. (This may be due
to an interaction between connection timeout and API timeout.)
This reverts commit 86f6a51 (#374).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes googleapis/python-bigquery-pandas#343
Fixes #394 🦕