Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restrict llvmlite version for Python 2.7/3.5 compatibility #79

Merged
merged 1 commit into from
Apr 20, 2020
Merged

chore: restrict llvmlite version for Python 2.7/3.5 compatibility #79

merged 1 commit into from
Apr 20, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 20, 2020 •
edited
Loading

Fixes #78. 🦕

This PR restricts the version of a problematic dependency that causes problems when installing on Python 2.7 and 3.5, since we still need to support these two Python versions at the time of writing.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Apr 20, 2020
@plamut plamut requested a review from shollyman April 20, 2020 13:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2020
@plamut plamut mentioned this pull request Apr 20, 2020
Merged
@plamut plamut merged commit c16438f into googleapis:master Apr 20, 2020
@plamut plamut deleted the iss-78 branch April 20, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests fail in Python 2.7, 3.5 (dependency issue)
3 participants
@plamut @shollyman @googlebot