Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add GH Workflow to run systests under emulator #430

Merged
merged 16 commits into from
Oct 12, 2021
Merged

chore: add GH Workflow to run systests under emulator #430

merged 16 commits into from
Oct 12, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 27, 2021 •
edited
Loading

Closes #431.

@tseaver tseaver requested review from a team as code owners September 27, 2021 19:32
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Sep 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2021
tseaver and others added 10 commits September 27, 2021 15:33
@tseaver
chore: tweak workflow trigger
f7fbdc6
@tseaver
chore: fix typo in setup-python action
13ac3cc
@tseaver
tests: ensure emulator is really stopped
5d53cf9 
Even if the tests are interrupted.  Also, they seem to need SIGKILL,
rather than SIGTERM.
@tseaver
tests: set project in environment for emulator systests
8567141
@tseaver
fix: force anonymous credentials under emulator
9bdee62 
Also, supply a dummy project ID if none us passed.
@tseaver
fix: skip unsupported instance / cluster admin tests under emulator
f1dfb6b
@gcf-owl-bot
🦉 Updates from OwlBot
e647e6d 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@tseaver
fix: preserve noxfile changes
7bdd049
@gcf-owl-bot
🦉 Updates from OwlBot
4e5533e 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@tseaver
fix: allow explicitly-passed credentials under emulator
85ee732
tseaver
tseaver commented Sep 29, 2021
View reviewed changes
google/cloud/bigtable/client.py Show resolved Hide resolved
noxfile.py Show resolved Hide resolved
@tseaver tseaver changed the title chore: add GH Workflow to run systests under emulator (DO NOT MERGE) chore: add GH Workflow to run systests under emulator Sep 29, 2021
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 29, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Sep 29, 2021

Before merging, update the workflow definition to run on PRs, rather than any push.

crwilcox
crwilcox reviewed Sep 29, 2021
View reviewed changes
google/cloud/bigtable/client.py Show resolved Hide resolved
tests/system/conftest.py Outdated Show resolved Hide resolved
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 4, 2021
@tseaver tseaver mentioned this pull request Oct 12, 2021
Closed
@crwilcox crwilcox merged commit f655c5a into main Oct 12, 2021
@crwilcox crwilcox deleted the tests-run-systests-under-emulator-gh-action branch October 12, 2021 15:38
@tseaver tseaver mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests: 'system_emulated' nox session fails in clean environment
2 participants
@tseaver @crwilcox