Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add presubmit scripts using kokoro #235

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 24, 2024

This PR includes code from #214 and code which was removed in #51

BEGIN_COMMIT_OVERRIDE
feat: build using Visual Studio 17 2022 instead of Visual Studio 16 2019
fix: drop support for Windows 32bit which is not supported in Visual Studio 17 2022
build: add Kokoro configuration files for presubmit testing
build: add Kokoro configuration files for continuous testing
fix: drop support for python 3.7 and 3.8
END_COMMIT_OVERRIDE

Towards #178
Towards #149

Co-authored-by: @vishwarajanand <vishwarajanand@users.noreply.github.com>
Co-authored-by: @andrewsg <andrewsg@users.noreply.github.com>
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 24, 2024
@@ -30,16 +30,14 @@ classifiers =
License :: OSI Approved :: Apache Software License
Operating System :: OS Independent
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.13 will be added in PR #233

@parthea parthea force-pushed the add-kokoro-configuration-files branch from 7ae2b59 to 9004a32 Compare August 26, 2024 13:31
@parthea parthea marked this pull request as ready for review August 26, 2024 13:32
@parthea parthea requested a review from a team as a code owner August 26, 2024 13:32
@parthea parthea requested a review from andrewsg August 26, 2024 13:32
@parthea parthea merged commit c1c8c59 into main Aug 27, 2024
14 checks passed
@parthea parthea deleted the add-kokoro-configuration-files branch August 27, 2024 11:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants