Skip to content

Commit

Permalink
chore: resolve issue with prerelease presubmit [autoapprove] (#339)
Browse files Browse the repository at this point in the history
* chore(python): fix prerelease session [autoapprove]

Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021

* update replacement in owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
  • Loading branch information
3 people authored Jul 29, 2022
1 parent 23417bd commit 1e34c4c
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 33 deletions.
4 changes: 2 additions & 2 deletions .github/.OwlBot.lock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-python:latest
digest: sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93
# created: 2022-07-14T01:58:16.015625351Z
digest: sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
# created: 2022-07-25T16:02:49.174178716Z
35 changes: 20 additions & 15 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,8 @@ def prerelease_deps(session):

# Install all dependencies
session.install("-e", ".[all, tests, tracing]")
session.install(*UNIT_TEST_STANDARD_DEPENDENCIES)
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
session.install(*unit_deps_all)
system_deps_all = (
SYSTEM_TEST_STANDARD_DEPENDENCIES
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
Expand Down Expand Up @@ -392,12 +393,6 @@ def prerelease_deps(session):

session.install(*constraints_deps)

if os.path.exists("samples/snippets/requirements.txt"):
session.install("-r", "samples/snippets/requirements.txt")

if os.path.exists("samples/snippets/requirements-test.txt"):
session.install("-r", "samples/snippets/requirements-test.txt")

prerel_deps = [
"protobuf",
# dependency of grpc
Expand Down Expand Up @@ -434,11 +429,21 @@ def prerelease_deps(session):
system_test_folder_path = os.path.join("tests", "system")

# Only run system tests if found.
if os.path.exists(system_test_path) or os.path.exists(system_test_folder_path):
session.run("py.test", "tests/system")

snippets_test_path = os.path.join("samples", "snippets")

# Only run samples tests if found.
if os.path.exists(snippets_test_path):
session.run("py.test", "samples/snippets")
if os.path.exists(system_test_path):
session.run(
"py.test",
"--verbose",
f"--junitxml=system_{session.python}_sponge_log.xml",
system_test_path,
env=env,
*session.posargs,
)
if os.path.exists(system_test_folder_path):
session.run(
"py.test",
"--verbose",
f"--junitxml=system_{session.python}_sponge_log.xml",
system_test_folder_path,
env=env,
*session.posargs,
)
24 changes: 8 additions & 16 deletions owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,26 +137,18 @@ def system(session, disable_grpc):
""",
)

assert 1 == s.replace(
assert 2 == s.replace(
"noxfile.py",
"""\
system_test_path,
""",
"""\
system_test_path,
env=env,
""",
"""system_test_path,\n""",
"""system_test_path,
env=env,\n""",
)

assert 1 == s.replace(
assert 2 == s.replace(
"noxfile.py",
"""\
system_test_folder_path,
""",
"""\
system_test_folder_path,
env=env,
""",
"""system_test_folder_path,\n""",
"""system_test_folder_path,
env=env,\n""",
)

# Add nox session to exercise doctests
Expand Down

0 comments on commit 1e34c4c

Please sign in to comment.