Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing docs for Firebase Admin #30

Closed
mik-laj opened this issue Mar 21, 2020 · 2 comments · Fixed by #174
Closed

Missing docs for Firebase Admin #30

mik-laj opened this issue Mar 21, 2020 · 2 comments · Fixed by #174
Assignees
@tseaver
Labels
api: firestore Issues related to the googleapis/python-firestore API. documentation Improvements or additions to documentation type: docs Improvement to the documentation for an API.

Comments

@mik-laj
Copy link

mik-laj commented Mar 21, 2020

Hello,

The documentation has serious defects. It has no documentation for FirestoreAdminClient
https://github.com/googleapis/python-firestore/blob/master/google/cloud/firestore_admin_v1/__init__.py#L36-L38
We only have documentation for FirestoreClient.

Best regards,
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 21, 2020
@mik-laj mik-laj mentioned this issue Mar 21, 2020
Closed
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 21, 2020
@HemangChothani HemangChothani self-assigned this Mar 23, 2020
@HemangChothani HemangChothani added documentation Improvements or additions to documentation type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. labels Mar 23, 2020
@HemangChothani
Copy link
Contributor

I think this is related to a gapic as it is auto-generated therefore their docs are also auto generated by artman. @crwilcox can you assign this to a responsible person or can i filed an issue against the generator.

@HemangChothani HemangChothani removed their assignment Mar 24, 2020
@turbaszek
Copy link

@HemangChothani @crwilcox any progress on this one?

@turbaszek turbaszek mentioned this issue Jul 20, 2020
Closed
@HemangChothani HemangChothani mentioned this issue Aug 24, 2020
Merged
tseaver pushed a commit that referenced this issue Aug 27, 2020
@HemangChothani
docs: document admin client (#174)
f099736 
Closes: #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the googleapis/python-firestore API. documentation Improvements or additions to documentation type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add document of admin client MaxxleLLC/python-firestore
5 participants
@tseaver @turbaszek @mik-laj @yoshi-automation @HemangChothani