Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restrict dependency of proto-plus #185

Closed
wants to merge 1 commit into from
Closed

chore: restrict dependency of proto-plus #185

wants to merge 1 commit into from

Conversation

HemangChothani
Copy link
Contributor

Fixes #184

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2020
@HemangChothani HemangChothani mentioned this pull request Sep 8, 2020
Merged
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Sep 9, 2020
@tseaver
Copy link
Contributor

tseaver commented Sep 14, 2020

#184 is closed: perhaps the issue you are seeing was related to googleapis/proto-plus-python#103, fixed in proto-plus 1.9.1?

@tseaver tseaver closed this Sep 14, 2020
@HemangChothani
Copy link
Contributor Author

@tseaver Yes, it's fixed in proto-plus 1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver Awaiting requested review from tseaver

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unit test failing in master branch
2 participants
@HemangChothani @tseaver