Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use native namespaces instead of pkg_resources #812

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Conversation

gkevinzheng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #730 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/python-logging API. labels Nov 15, 2023
@gkevinzheng gkevinzheng marked this pull request as ready for review November 16, 2023 18:20
@gkevinzheng gkevinzheng requested review from a team as code owners November 16, 2023 18:20
@gkevinzheng gkevinzheng requested a review from parthea November 16, 2023 18:20
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2023
@parthea
Copy link
Contributor

parthea commented Nov 16, 2023

Adding do not merge as there is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please could you add tests as well similar to googleapis/google-auth-library-python#1205?

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2023
@parthea parthea enabled auto-merge (squash) November 29, 2023 17:26
@parthea parthea merged commit 10ad75d into main Nov 29, 2023
16 of 18 checks passed
@parthea parthea deleted the native-namespace branch November 29, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning for pkg_resources.declare_namespace("google.logging")
3 participants