-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compressed=True support to TextProperty #277
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
snarfed
added a commit
to snarfed/bridgy
that referenced
this issue
Dec 15, 2019
…_json google.cloud.ndb doesn't support TextProperty(compressed=True) yet, either explicitly or implicitly, but Source.seen_responses_cache_json is one, so we need to support its existing values in the datastore. also see googleapis/python-ndb#277
cguardia
added
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
and removed
triage me
I really want to be triaged.
labels
Dec 18, 2019
@snarfed Thanks, we'll see what we can do. |
snarfed
added a commit
to snarfed/bridgy
that referenced
this issue
Dec 20, 2019
…_json google.cloud.ndb doesn't support TextProperty(compressed=True) yet, either explicitly or implicitly, but Source.seen_responses_cache_json is one, so we need to support its existing values in the datastore. also see googleapis/python-ndb#277
chrisrossi
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
and removed
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
labels
Feb 20, 2020
Changing this to "bug", because it is a regression. |
chrisrossi
pushed a commit
to chrisrossi/python-ndb
that referenced
this issue
Feb 21, 2020
chrisrossi
pushed a commit
that referenced
this issue
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
hi all! i recently hit an issue migrating an app from
google.appengine.ext.ndb
with aTextProperty(compressed=True)
, which isn't supported ingoogle.cloud.ndb
. (i'm on 0.2.0, on the Python 3 Standard runtime.)i saw #160 and the fix in #181, particularly "we can still support compression transparently with bidirectional compatibility," and optimistically tried just removing
compressed=True
, but no luck. the value comes back as the raw zlib-compressed bytes, egb'x\x9c\xed\\ks\xdb...'
.i ended up adding support myself with this custom property class:
it'd be nice if
google.cloud.ndb
supported this natively!The text was updated successfully, but these errors were encountered: