[Python 2] repeated StructuredProperty returns as empty list

[rpanaro]

Environment details

Python 2.7.17
google-cloud-ndb 1.0.1

Steps to reproduce

Currently trying to finish migration from old ndb and my repeated StructuredProperty returns from queries as empty lists. I suppose the data is in legacy format.

Code example

Models:

class Day(ndb.Model):
   times = ndb.StructuredProperty(Timespan, 't', repeated = True)
   ...

class Timespan(ndb.Model):
   start = ndb.IntegerProperty('s', required = True)
   duration = ndb.IntegerProperty('d', required = True)
   varies = ndb.BooleanProperty('v')
   title = ndb.StringProperty('t')
   l = ndb.ComputedProperty(lambda self: self.title.lower())
   color = ndb.StringProperty('c')
   detail = ndb.TextProperty('i')

Query:
day = Day.query([filter]).get() results in day.times being []

Data Log

on Read & Write:

....
    properties {
      key: "t.c"
      value {
        array_value {
          values {
            string_value: "blue"
          }
          values {
            string_value: "green"
          }
        }
      }
    }
    properties {
      key: "t.d"
      value {
        array_value {
          values {
            integer_value: 3
          }
          values {
            integer_value: 4
          }
        }
      }
    }
    properties {
      key: "t.i"
      value {
        array_value {
          values {
            string_value: "foo text"
          }
          values {
            string_value: "bar text"
          }
        }
      }
    }
    properties {
      key: "t.l"
      value {
        array_value {
          values {
            string_value: "foo"
          }
          values {
            string_value: "bar"
          }
        }
      }
    }
    properties {
      key: "t.s"
      value {
        array_value {
          values {
            integer_value: 58
          }
          values {
            integer_value: 66
          }
        }
      }
    }
    properties {
      key: "t.t"
      value {
        array_value {
          values {
            string_value: "foo"
          }
          values {
            string_value: "bar"
          }
        }
      }
    }
    properties {
      key: "t.v"
      value {
        array_value {
          values {
            null_value: NULL_VALUE
          }
          values {
            null_value: NULL_VALUE
          }
        }
      }
    }
...

Possibly similar to a combo of #122 and/or #300 ??

[cguardia]

@rpanaro there's a bug in the handling of legacy structured properties with names that differ from code names (like "t" instead of "times"). Fix coming up today.

[cguardia]

Fixed via #347.

[rpanaro]

@cguardia Ah, my old friend over-optimization strikes again! Thanks much Carlos. Appreciate ya